Hi Jan.
Thanks for the clarification and for adjusting the bug report.
LGTM.
Thanks,
Jack
On 08/17/11 11:23 PM, Jan Damborsky wrote:
Thank you for review, Jack.
Please see my response in-line.
Jan
On 08/17/11 19:33, Jack Schwartz wrote:
Hi Jan.
The bug report description is confusing. In PP 2, it says to make a
symlink to /var/install/log. In PP 4, it says the symlink will go to
/var/log/install. Please correct the description.
Yep, you are right. Thank you for catching this. I have corrected that.
Also, the bug synopsis says /var/install/log while the fix is to
/var/log/install. Based on what you said in the testing section of
the email, it sounds like /var/log/install is indeed correct, so
please correct the synopsis.
Done.
In the testing reported in your email, pkg update -v found files it
didn't know what to do with. Is this because the original package
didn't set up /var/sadm/system/logs?
I assume you are referring to following statement:
The following unexpected or editable files and directories were
salvaged while executing the requested package operation; they
have been moved to the displayed location in the image:
var/sadm/system/logs ->
/var/pkg/lost+found/var/sadm/system/logs-20110817T070028Z
The reason for this action is that before 'pkg update'
/var/sadm/system/logs
is a regular non-empty directory. Since that directory is to be removed
as a result up 'pkg update' and replaced with just a symlink, pkg
preserves
content of that directory in /var/pkg/lost+found/.
Thanks,
Jack
On 08/17/11 04:38 AM, Jan Damborsky wrote:
Hi all,
I would appreciate review of one line change which is supposed to
address
7079233 Deliver /var/sadm/system/logs as a symlink to /var/install/log
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7079233/webrev/
Thank you,
Jan
tests done:
* built LiveCD and tested installation - installed system booted
successfully -
install log file correctly landed in /var/log/install/ directory:
$ ls -l /var/sadm/system/logs
lrwxrwxrwx 1 root root 17 Aug 17 13:11
/var/sadm/system/logs -> ../../log/install
$ ls -l /var/sadm/system/logs/
total 40
-rw-r--r-- 1 root staff 19706 Aug 17 13:30 install_log
$ ls -l /var/log/install/
total 40
-rw-r--r-- 1 root staff 19706 Aug 17 13:30 install_log
$
* on 171, 'pkg update' run to install modified system/install:
# pkg set-publisher --non-sticky -O http://ipkg.cz.oracle.com solaris
# pkg set-publisher -p
file:///net/tio/export/home/dambi/ws/cr-7079233/packages/i386/nightly-nd/repo.redist/
--search-before=solaris
pkg set-publisher:
Added publisher(s): install-nightly
# pkg uninstall entire
Packages to remove: 1
Create boot environment: No
PHASE ACTIONS
Removal Phase 60/60
PHASE ITEMS
Package State Update Phase 1/1
Package Cache Update Phase 1/1
Image State Update Phase 2/2
# pkg update -v
Packages to update: 8
Estimated space available: 59.26 GB
Estimated space to be consumed: 150.29 MB
Create boot environment: No
Services to change: 1
Rebuild boot archive: No
Changed packages:
solaris -> install-nightly
consolidation/install/install-incorporation
0.5.11,5.11-0.171:20110801T123357Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063857Z
install/installadm
0.5.11,5.11-0.171:20110801T123418Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063858Z
system/install
0.5.11,5.11-0.171:20110801T123634Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063859Z
system/install/auto-install
0.5.11,5.11-0.171:20110801T123456Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063858Z
system/install/auto-install/auto-install-common
0.5.11,5.11-0.171:20110801T123444Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063858Z
system/install/configuration
0.5.11,5.11-0.171:20110801T123501Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063858Z
system/install/tests
0.5.11,5.11-0.171:20110801T123545Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063858Z
system/library/install
0.5.11,5.11-0.171:20110801T123702Z ->
0.5.11,5.11-0.173.0.0.0.0.1394:20110817T063859Z
Services:
restart_fmri:
svc:/system/install/server:default
DOWNLOAD PKGS FILES XFER (MB)
Completed 8/8 242/242 1.1/1.1
PHASE ACTIONS
Removal Phase 122/122
Install Phase 44/44
Update Phase 257/257
PHASE ITEMS
Package State Update Phase 16/16
Package Cache Update Phase 8/8
Image State Update Phase 2/2
The following unexpected or editable files and directories were
salvaged while executing the requested package operation; they
have been moved to the displayed location in the image:
var/sadm/system/logs ->
/var/pkg/lost+found/var/sadm/system/logs-20110817T070028Z
---------------------------------------------------------------------------
NOTE: Please review release notes posted at:
http://download.oracle.com/docs/cd/E19963-01/
---------------------------------------------------------------------------
# ls -l /var/sadm/system/logs
lrwxrwxrwx 1 root root 17 Aug 17 07:00
/var/sadm/system/logs -> ../../log/install
# ls -l /var/sadm/system/logs/
total 0
#
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
