On 08/18/11 17:39, Jan Damborsky wrote:
On 08/18/11 18:11, Dave Miner wrote:
On 08/18/11 11:51, Jesse Butler wrote:
This looks good. My only high level comment is that my assumption
around "label" and "name" are the opposite of what you have - I feel
like the actual NIC driver name and instance (e.g. 'e1000g2') would
be referred to as "name", and the vanity name (e.g. 'net3') might be
considered a 'label'. I'll leave it up to you whether you want to
pursue that or not...
I agree that label is probably not a good term here; I'd suggest
instead saying "device" or perhaps better, "link".
Thank you for review, Dave.
I have taken a look at dladm man page and 'link' seems to be used as
more generic term, so I went with 'device'.
I have updated webrev accordingly:
full:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7078155-cr/webrev-cr/
incremental:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7078155-cr-diff/webrev-cr-diff/
Looks OK.
Dave
Jan
Dave
One minor comment, as well. In network_info.py, on line 161 is it
necessary to check both len returned and also for each element to be
set? In other words, is it possible to get a return back that doesn't
include the NIC driver+instance (e.g. 'e1000g2'). If not, you could
just check for len == 2 and assign, right?
if len(vanity_device) == 2:
(n_name, n_label) = vanity_device
Best
Jesse
On Aug 18, 2011, at 10:29 AM, Jan Damborsky wrote:
Hi all,
could I please ask two pair of eyes to take a look at fix for
7078155 snv171 text installer provides insufficient NIC information
after vanity-naming-by default went in.
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7078155/webrev/
Thank you,
Jan
tests done:
* installation with modified Sparc text installer booted from network
* installation with modified x86 text installer booted from media
* configuration of non-global zone with exclusive IP stack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
