Thanks Darren and Dermot,
Made chance you requested and posted new webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7080223.2/
cheers
Matt
On 08/19/11 11:45, Darren Kenny wrote:
Hi Matt,
Looks good to me...
A small nit - which you can ignore if you wish - I'm not sure if there is much
to be gained by adding the "and not found_install_sw_data", since all that will
happen next is to assign the same value to it. I personally feel it more
readable without...
Thanks,
Darren.
On 18/08/2011 16:29, Matt Keenan wrote:
Hi,
Can I get two pairs of eyes to look over fix for bug :
7080223 AI over zealous in software packages validation
http://monaco.sfbay.sun.com/detail.jsf?cr=7080223
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7080223/
AI currently validates when addeding transfer checkpoints that every
Software element in the manifest must contain a software_data section of
action "install".
This really is not necessary, and really should only check that at least
one of the software sections contains a software_data section of action
"install".
CR also address missing checking for P5I install types and fixes a test
regression.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
