Hi Dermot,

Thank you for the review.

Slightly delaying the start of the target discovery thread will
not delay text installer start up time at all.  Delaying the start
means target discovery might not have completed when
the user hit continue after viewing the Welcome screen.
If target discovery is not completed when the user
advance to the disk screen, they will see the "spinning sign"
indicating target discovery is still happening.  When target discovery
completes, the disk screen will display as usual.  Running target discovery
in a thread while other screens are initialized was an attempt
to minimize the amount of time the "spinning sign" is displayed
when the user goes to the disk selection screen, if they have
a large number of disks on their system. It does not
affect text installer start time at all.

Thanks,

--Karen


On 08/19/11 02:14 AM, Dermot McCluskey wrote:
Karen,

I'm OK with this fix, too, but as you note it seems
to be a Python bug that we need to work around
until our Python is upgraded.

btw - do you have any guess as to how much of a
delay this causes in TextInstall startupup?

- Dermot



On 08/18/11 23:38, Karen Tung wrote:
Good afternoon,

I am looking for 2 reviewers for my change to fix the following bug:
7080384  <http://monaco.us.oracle.com/detail.jsf?cr=7080384>  Unable to get 
past install menu during sparc text install

webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/Popen-problem/webrev/

The fix is relatively simple, but please read my evaluation and suggested fix in the bug report
to make sure you agree with why I choose to fix the bug this way.

I tried my fix on the machine that consistently experience the problem, and verified
that I can start the text installer multiple times after this fix.

Thanks,

--Karen




_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to