Hi John,
This looks good, but I'd like to request a few
minor changes:
- 83-130, Move all 5 new calls toself.builder.get_object()
up to line 74 with the others
- then you can also add the 5 new variables to the check
for Glade errors at line 75.
- 234-237, assign the msg to a var and reuse it, rather
than define it twice
Dermot
On 08/19/11 16:45, John Fischer wrote:
All,
Can I get a review for CR 7074323:
http://monaco.us.oracle.com/detail.jsf?cr=7074323
[A11Y]Warning message should be accessible in Solaris Installer
User page.
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7074323-a11y-user-screen/
This is a high priority fix because it will cause service calls. I've
already sent
email to Dave asking for integration approval which he granted.
The fix for this is to ensure that the label for the entry and the
warning
label are associated with the entry. For example, the loginnamelabel and
loginnameinfolabel need to have a relation with the usernameentry.
Currently, only the loginnamelabel has a relation with the usernameentry.
The fix does not accessibly display the error as it occurs but does once
the user returns to the entry widget. I believe that this is OK
because if
the user attempts to move to the next screen a warning dialog pops up
describing the failure which is accessible and then user will then
return to
the entry with the error getting the warning.
This a is low risk fix though slightly higher then the previous
accessibility fix.
I have installed a system with and without using Accessibility
technology.
All installs now work properly.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
