Drew,

On 08/22/11 17:05, Drew Fisher wrote:
Dermot,

confirm_screen.py
----------------

182-183:  will Partition.is_solaris() not work for you?

solaris_partitions = [part for part in partitions if part.is_solaris()]

Yes, that's better, but it will only work without
the (), as is_solaris is a property, not a callable.

Thanks,
- Dermot




Otherwise, this looks fine.

-Drew

On 8/22/11 9:50 AM, Dermot McCluskey wrote:
Hi,

Can I get a couple of reviewers for this fairly
simple fix for GUI Install:


http://monaco.sfbay.sun.com/detail.jsf?cr=7081847
Installer summary page shows disk used when partition selected for install

Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7081847/

Tested GUI Install to ensure it always prints a confirmation
message about the Solaris2 partition being installed to,
instead of just the disk.

Thanks,
- Dermot

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to