One nit, can you update the comment to refer to a broken symlink, since that's 
what exists() will return False on? Otherwise, looks good!
/jb

On Aug 24, 2011, at 11:44 AM, Drew Fisher wrote:

> Good morning,
> 
> Could I please get a code review for:
> 
> 7061216 Dangling symlink in media directory causes DC traceback in create_iso
> 
> https://cr.opensolaris.org/action/browse/caiman/drewfish/7061216/webrev/
> 
> I tested this by creating ISOs both with timestamp set to 'true' and 'false' 
> along with full files, symlinks and missing symlinks.  
> 
> Thanks!
> 
> -Drew
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to