Looks good to me, Harold!
/jb

On Aug 30, 2011, at 3:18 PM, Harold Shaw wrote:

> Could I please get a couple of reviews for the fixes for the following bugs:
> 
> 7083455 distro_const should transliterate '.' to '_' in the build name when 
> creating AI images (pkg & iso)
> 7083780 prefix argument to ai_publish_pkg is poorly named
> The webrev is located at: 
> 
> https://cr.opensolaris.org/action/browse/caiman/hshaw/7083455/webrev/
> 
> For 7083455, I verified that the '.'s are translated to '_'s, that this 
> service name is used if no name is specified when creating a service and that 
> it will successfully boot on the client.  This was done with both an iso and 
> the image package.
> 
> For 7083780, I verified that distro constructor will successfully create the 
> image package if the 'publisher' value is explicitly defined in the manifest 
> and also in the default case when it is not.  Services were successfully 
> created in both cases.
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to