Thanks for reviewing, Drew & John.
- Dermot
On 08/31/11 15:06, John Fischer wrote:
Looks good to me too...
John
On 08/31/11 06:53 AM, Drew Fisher wrote:
LTGM!
-Drew
On 8/31/11 7:33 AM, Dermot McCluskey wrote:
Hi,
I'm looking for a couple of code reviews and approval to
integrate into b174 these two low-risk L10N-related fixes
for GUI Install.
7085402 <http://monaco.us.oracle.com/detail.jsf?cr=7085402> gui-install
introduces localiziable string with non-swappable parameters
7085328 <http://monaco.us.oracle.com/detail.jsf?cr=7085328> Localized gui-install, the string
"Finding Disks" in "Disk" panel are displayed in English.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7085328-708540/
Details:
7085402 - use dictionary/key format for displayed string with
multiple interpolated variables. Also, use locale.format() for
displayed numeric values.
7085328 - use the "delayed translation" mechanism for this
string which is defined immediately at startup, before localization
has been setup.
Testing:
Tested in C, fr_FR.UTF-8 and de_DE.UTF-8 and confirmed fixes
and no regressions. Complete testing cannot be done until
message catalogs are updated in a future build.
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
