LGTM Niall, Darren.
On 02/09/2011 05:23, Niall Power wrote: > Good evening! > > I'm looking for a couple of eyes on my webrev for 7085314: > > http://monaco.us.oracle.com/detail.jsf?cr=7085314 > > > Webrev is at: > https://cr.opensolaris.org/action/browse/caiman/niall/7085314/webrev-7085314/ > > > I've tested the fix by creating ISO images for AI, Text and LiveCD and > verifying the grub menus > are appropriate. I have also checked the system boot menu (2) fix by > installation via text-install and > gui-install and rebooted to verify that the grub menus were set up > correctly. > > The fix is broken down into 2 major components: > 1. Construction of grub menu for ISO images of LiveCD, Text and AI > 2. Runtime configuration of grub menu for system installation > > 1. Construction of grub menu for ISO images of LiveCD, Text and AI > > The problem here was that the Text Install (and AI) iso images were > using a graphical boot splash > *inherited from pybootmgmt as the default configuration). This is > inappropriate for serial console > devices without graphical capabilities to display the splash. This > impacts both Text Install and AI ISO > images. > The fix is to set the console type to "PROP_CONSOLE_TEXT" via. the > pybootmgmt bootconfig instance > > Additionally, the Text ISO, prior to CUD version used to hide the menu > with a 5 second timeout. I have > fixed this to be consistent with the old pre-CUD Text ISO > > 2. Runtime configuration of grub menu for system installation > > To complement (1), during system installation, graphical boot splash > needs to be disabled for Text and > AI based installs and only enabled for LiveCD based installation on a > graphical console device. > To detect a LiveCD installation I check the DOC for the "GUI Install" > profile data object which is unique > to the LiveCD/gui-install application. > > Thanks, > Niall > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
