On 09/ 7/11 09:18 AM, Dave Miner wrote:
On 09/07/11 11:11, Virginia Wray wrote:
Hi --
This is a stopper bug that I would like to get back quickly, so
that we can redeliver for build 174.
Jan has code reviewed. Can I get one more reviewer
and Dave's ok?
CR:
http://monaco.us.oracle.com/detail.jsf?cr=7087609
Webrev:
file:///net/indiana-build.us.oracle.com/data/share/vw130254/projectwork/sys-unconfig/7087609/slim_source/webrev/index.html
Just to be clear, the end result here is that create-profile still
works for whatever groupings are specified, and configure and
unconfigure still only work with system? And you've tested that,
right? :-)
Dave
yes. I tested all three cases with my fix last night. (I don't blame you
for asking. :) )
create-profile and the configure/unconfigure paths are different...
If you look in the code review, if the sub_cmd is create_profile (line 514),
it checks to make sure the groupings requested are valid. This is actually
what was broken, since the svccfg command was now only returning "system".
The else portion (line 523) is for the configure/unconfigure case. It
doesn't
allow anything but "system". This wasn't broken. The reason the
configure was
breaking is because the config milestone calls sysconfig create-profile.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
