Karen,
Looks good to me too. I would only change the wording:
206 err_msg = "There should only be 1 gap in partition" \
207 " %s, but %d gaps are found." % \
to:
err_msg = "There should only be 1 gap in partition" \
" %s, but %d gaps were found." % \
Keep up the great work.
John
On Sep 7, 2011, at 9:58 AM, Drew Fisher wrote:
> Karen,
>
> This looks good to me. Can you verify that the targets and AI unittests
> still run correctly?
>
> -Drew
>
> On 9/7/11 10:50 AM, Karen Tung wrote:
>>
>> Good morning,
>>
>> I would like a couple of reviewers to look at my changes for the following
>> bugs.
>>
>> 7087586 Problems with target controller applying the wrong default layout
>> 7087182 S11 text installer crashes ("Desired target doesn't pass final
>> validation") for empty 0xbf partition
>> webrev:
>>
>> https://cr.opensolaris.org/action/browse/caiman/ktung/partition-bugs/webrev/
>>
>> Thanks,
>>
>> --Karen
>>
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
