On 08/09/2011 16:15, Dave Miner wrote:
> Darren, while you're in here:
>
> IPS fixed 18835 a couple of weeks ago, so flush-content-cache-on-success
> now defaults to true, so we should remove that setting from
> zone_default.xml.src.
Done.
>
> The remaining comment in ai_manifest.xml.src regarding languages is
> really awkward. How about "Language localizations are selected using
> package facets. The below stanza selects the languages that are
> standard on Solaris installation."
>
Changed to this. Updated webrev at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7087641-2/webrev/
Thanks,
Darren.
> Dave
>
> On 09/08/11 03:23, Darren Kenny wrote:
>> Ehm, yep, shouldn't have done this at such a late hour ;)
>>
>> The updated review is at:
>>
>> https://cr.opensolaris.org/action/browse/caiman/dkenny/7087641-1/webrev/
>>
>> Thanks,
>>
>> Darren.
>>
>> On 08/09/2011 00:18, Ethan Quach wrote:
>>> Hey Darren,
>>>
>>> Per the eval, doesn't zone_default.xml need to be modified as well?
>>>
>>> -ethan
>>>
>>>
>>> On 09/07/11 15:05, Darren Kenny wrote:
>>>> Hi,
>>>>
>>>> Could I please get a review and approval of the fix for:
>>>>
>>>> 7087641 Need locale facet defaults (and samples) in AI
>>>>
>>>> The webrev is at:
>>>>
>>>> https://cr.opensolaris.org/action/browse/caiman/dkenny/7087641/webrev/
>>>>
>>>> It essentially just adds the facets specification to the distributed
>>>> default.xml
>>>> and ai_manifest.xml files.
>>>>
>>>> I have not used XInclude since this would require that the file also be
>>>> downloaded to the AI client itself, which is not a change likely to be
>>>> made at
>>>> this point.
>>>>
>>>> Thanks,
>>>>
>>>> Darren.
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> [email protected]
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> [email protected]
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
