Hi William.

Please update the bug report with suggested fix, and note there what you say here about the logic change due to 7073565.

Even though it's after the fact, please also update the suggested fix in 7073565. I was able to revisit these changes using hg log and hg diff -c, but it will be easier in the future in case someone has to revisit it again.

Code changes proper LGTM.

    Thanks,
    Jack

On 09/ 7/11 02:13 PM, William Schumann wrote:
https://cr.opensolaris.org/action/browse/caiman/wmsch/7087926/webrev/

In 7073565 snv_169 text installer: edited numeric fields eat the Escape sequences, the logic was changed so that None is returned in the event of an invalid escape sequence instead of the terminator character. Test changed to expect None for an invalid escape sequence.

Retested test.

Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to