Hi Seth,
I've taken your suggestions on board - but kept the "bios" part in the
file name :-)
So now it is ".bios-eltorito-img" instead of "bios-eltorito-boot"
New webrev:
https://cr.opensolaris.org/action/browse/caiman/niall/7052879-1/webrev-7052879-1/
Cheers,
Niall
On 09/09/11 16:00, Seth Goldberg wrote:
Hi,
I'd prefer a name like ".eltorito" or "eltorito-boot.img", but feel
free to override me :).
--S
On Sep 8, 2011, at 10:52 PM, Niall Power wrote:
Hi all,
I'd like to request a code review for my fix for the following bug:
*7052879 DC did not clean up tmpMPheZ_ in pkg_image area
<http://monaco.sfbay.sun.com/detail.jsf?cr=7052879>*
http://monaco.sfbay.sun.com/detail.jsf?cr=7052879
Webrev:
https://cr.opensolaris.org/action/browse/caiman/niall/7052879/webrev-7052879/
Analysis:
The tmpXYZ file is not meant to be temporary as it must be part of
the ISO image
in order to enable the ISO to boot. The issue is that the random name
prefixed by
tmp makes it look it doesn't belong there. The fix is simply to
rename/relocate it
before the ISO is created so that it doesn't draw unnecessary attention.
Testing Performed:
I've rebuilt DC, Text and LiveCD ISOs and confirmed that they all
boot and that the
temporary file name is now gone and replaced by
'boot/bios-eltorito-boot' under the
root of the ISO filesystem.
Unit tests for the boot module have also been checked and confirmed
to still pass.
Changes are PEP8 clean.
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
