Harold,

This looks good to me.

Sue

On 09/09/11 15:09, Harold Shaw wrote:
Can I get a review and putback approval for:

Webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/7088900/webrev/

Bugid:

7088900  <http://monaco.us.oracle.com/detail.jsf?cr=7088900>  Fix for7085268  
<http://monaco.us.oracle.com/detail.jsf?cr=7085268>  causes a regression in 
rename-service



This bug was causing installadm rename-service to fail for services that
had an alias. The problem was caused by a change in the order in
update_basesvc. It is necessary to update the config properties of the
alias before attempting to call mounted().

The following tests were run:
- manual tests of both set-service and rename-service
- installadm test suite rename-service test cases were run to verify the fix
- The full installadm test suite is in progress to check for
regressions. No putback will be done until the tests are complete and
results verified.
- unit tests were run (There were 2 failures but checks reveal that
neither are caused by this putback. Unit test bugs to be filed)
- pep8 clean



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to