On Sep 9, 2011, at 7:51 PM, Drew Fisher wrote: > > > On 9/9/11 8:10 PM, Dave Miner wrote: >> On 09/09/11 22:02, Drew Fisher wrote: >>> Good evening! >>> >>> Could I please get a code review for a fairly simple CR: >>> >>> 7088855 <http://monaco.us.oracle.com/detail.jsf?cr=7088855> bad drive >>> leads to failed auto-install assertion >>> >>> https://cr.opensolaris.org/action/browse/caiman/drewfish/7088855/webrev/ >>> >>> I ran the target unittests and saw no new regressions. I also tested on >>> Mike's machine (where the problem originally presented itself). We now >>> properly skip the broken drive. >>> >>> We have to do the check where it is, because for failing / failed / >>> broken drives, accessing the media attributes actually causes the >>> failure so we have to do this first. >>> >> >> Is there any way we get here with a drive that doesn't have an s2 in the >> label? > > I honestly don't know that answer. :( I could always try s2 first, then try > s0, then just give up and continue, maybe?
Could this code induce a long timeout during the read()? (I'm thinking of an iSCSI disk whose host is inaccessible, for example). --S > > >> >> >> Nit: I'd feel a bit better if you had a close in there, but I suppose we're >> just in the sub-process and relying on exit to close them. > > Oops. I'll happily put a close in there. > > -Drew > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
