Approved. Dave
On 09/12/11 14:22, William Schumann wrote:
Takeshi, Caimaners, Takeshi discovered that the locale.atof() must have input encoded according to locale or it crashes. I verified this and took his coding recommendations with changes for readability. The French locale differs in that floating point uses commas instead of decimal points. Also, in on_exit_edit(), which is called when user moves off an input field for partition sizes, changed so that it sets the user's edit field only when the user leaves it blank. Tested by selecting French language during text installer boot, regression tested using default locale, current nightly. Target instantiation, install finish without error. Checked partitioning on reboot - values consistent with what user input. Found bug and filed CR 7089672 during unit testing - appears unrelated. https://cr.opensolaris.org/action/browse/caiman/wmsch/7089436/webrev/ Fluency in French is not required to review this fix. Thank you, William _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
