LGTM. On Sep 12, 2011, at 4:32 PM, Jack Schwartz <[email protected]> wrote:
> Hi everyone. > > Here is a pretty simple code review (a whopping 7 lines) for the following > two bugs: > > 7088460 Race condition between converting py.src->py files and python -m > compileall in some Makefiles > 7087552 Debris from media carried over to installed system > > Webrev: > https://cr.opensolaris.org/action/browse/caiman/schwartz/7088460_1 > > Bug reports: > http://monaco.us.oracle.com/detail.jsf?cr=7088460 > http://monaco.us.oracle.com/detail.jsf?cr=7087552 > > Testing: > > 7088460: > - I verified that the gate builds, and all files managed by the changed > Makefiles get copied to their respective places. Being a race condition, the > problem is not readily reproducable. > > 70875532: > - I reproduced /save existed on installed targets produced from live CD and > text-installer images. I then verified /save went away on installed targets > of both images with my fix. > > Notes: > - /mangled is still present during testing as that is no longer being fixed > by this bug. (See bug report.) > - /tmpxxxx was fixed earlier today by Niall as 7052879, and is not part of > this bug. > > > Thanks, > Jack > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
