LGTM.
-Drew
On 9/12/11 5:39 PM, Sue Sohn wrote:
Comments from Karen and Drew are reflected in updated webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7089691_2/webrev.7089691_2
Sue
On 09/12/11 14:54, Drew Fisher wrote:
Also, could you make return_false a lambda?
com.is_multihomed = lambda x: return False
-Drew
On 9/12/11 3:07 PM, Karen Tung wrote:
Hi Sue,
The changes look OK to me.
Can you get a comment for the setUpClass() function to explain
why that setup is necessary? Now, I know
you are trying make sure com.is_multihomed() function always returns
False for the tests because I read the bug. In the future, people who
is reading the code might not understand.
Thanks,
--Karen
On 09/12/11 13:51, Sue Sohn wrote:
Can I get a code review of the changes for:
7089691 unit_test for create_service shouldn't assume installadm is
installed
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7089691/webrev.7089691
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
