Hi everyone.

Seeking two reviews by Thursday COB and Dave's approval please. I'd like to request Ethan be one of the reviewers.

Here is a code review that fixes a hole in aimanifest path processing. Without this bugfix,
  aimanifest add diskname@name c0t0d0s0
or other references to non-absolute paths which have no values in them fails.

webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7090604_1

bug report:
http://monaco.us.oracle.com/detail.jsf?cr=7090604

While it introduces a new method to find the path leading to the referenced element, all code introduced by this fix affects only the failing cases; codepaths of working cases are not affected.*

* While in there, I added some additional args checking for set(), get() and add(), which I have tested but can remove if it makes the difference between being allowed in or not.

    Thanks for your time,
    Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to