LGTM Ginnie Darren.
On 16/09/2011 00:12, Virginia Wray wrote: > You are correct...for some reason, I thought the others had > been picked up in the same manner that Dermot did with the gui-installer. > I have no idea why I thought that. Sorry about that. > > Here is an updated webrev. > https://cr.opensolaris.org/action/browse/caiman/ginnie/7072062/webrev/ > > I performed the same checks. Installed the install-incorporation on my test > machine, and saw the following > > root@jumprope:~# !24 > pkg search -l 'depend::system/install/locale' > INDEX ACTION VALUE > PACKAGE > incorporate depend system/install/[email protected],5.11-0.174.0.0.0.0.744 > pkg:/consolidation/l10n/[email protected] > group depend system/install/locale > pkg:/group/system/[email protected] > require depend system/install/locale > pkg:/system/install/auto-install/[email protected] > require depend system/install/locale > pkg:/system/install/[email protected] > require depend system/install/locale > pkg:/install/[email protected] > > > thanks, > ginnie > > On 09/15/11 01:17 PM, Virginia Wray wrote: >> Hi -- >> >> This adds the locale dependency to the configuration package. >> >> Could I get two reviewers, and then Dave's approval, if appropriate. >> >> CR: >> http://monaco.us.oracle.com/detail.jsf?cr=7072062 >> >> >> Webrev: >> https://cr.opensolaris.org/action/browse/caiman/ginnie/7072062/webrev/ >> >> I set up a pkg repo and observed the dependency in the manifest. >> >> I also installed the package on a test system and ran the following >> command with the following output: >> >> root@jumprope:~# pkg search -l 'depend::system/install/locale' >> INDEX ACTION VALUE >> PACKAGE >> group depend system/install/locale >> pkg:/group/system/[email protected] >> incorporate depend system/install/[email protected],5.11-0.174.0.0.0.0.744 >> pkg:/consolidation/l10n/[email protected] >> require depend system/install/locale >> pkg:/system/install/[email protected] >> root@jumprope:~# >> >> >> Thanks, >> ginnie >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
