Thanks Drew.
-- Sent from my Palm Pixi On Sep 19, 2011 6:14 PM, Drew Fisher <[email protected]> wrote: LGTM, too! -Drew On 9/19/11 6:11 PM, John Fischer wrote: > All, > > I know that it is very late but CR 7092491 is a really bad usability bug: > > http://monaco.us.oracle.com/detail.jsf?cr=7092491 > GUI installer doesn't report tracebacks > > What makes this so bad is that the GUI does not advance to the failure > screen from the progress screen. Thus it appears that the installer > is either hung or the install is still continuing. I think that this > is bad > enough to warrant a late push. > > The webrev is located at: > > > https://cr.opensolaris.org/action/browse/caiman/johnfisc/7092491-GUI-failure > > The fix is simple and low risk. I just need to add: > > self.install_complete = True > > within the error section of the install_callback() method of the > ProgressScreen > class. the self.install_complete simply means that the installer has > completed > the process. There is also a self.success that records whether or not > it was > successful. > > I have tested this within a GUI install that I setup to fail. With > the fix the > screen does advance to the failure screen and the log has been > appropriately > updated. > > Thanks, > > John > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
