I was looking for a place where this file could just be tacked onto another list of files already being preserved and restored, but it doesn't look like there's a good fit. So, this looks OK to me.
On Sep 20, 2011, at 10:02 PM, Drew Fisher wrote: > Good evening! > > Could I please get a code review for: > > 7092161 /boot/grub/menu.lst on the installed system is incorrect > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7092161/webrev/ > > I tested this by building a livecd.iso. I paused DC after running > pre-pkg-img-mod and boot/grub/menu.lst was saved in the correct /save > directory: > > ls -l /rpool/cr_7092161/dc/livecd/build_data/pkg_image/save/boot/grub/menu.lst > > -rw-r--r-- 1 root sys 1546 Sep 20 14:58 > /rpool/cr_7092161/dc/livecd/build_data/pkg_image/save/boot/grub/menu.lst > > I fully installed the ISO and after rebooting, the correct version of > menu.lst is present. > > There's a larger issue with pre-pkg-img-mod in that the checkpoint is > inconsistently using the save_files_directories() method. Some things use > it, some things don't. Since I didn't want to risk any drastic changes to > the checkpoint this close to FCS, I've filed 7093060 to cover that work. > > Thanks! > > -Drew > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
