On 09/21/2011 06:10 PM, Kristina Tripp wrote:
See comments below
-------- Original Message --------
Subject: Re: [caiman-discuss] code review request for 7091163, 7091196,
7092486, 7092529, 7091377
Date: Wed, 21 Sep 2011 01:16:44 -0700 (PDT)
From: Jan Damborsky <[email protected]>
To: Kristina Tripp <[email protected]>
CC: [email protected]
Hi Kristina,
thank you very much for addressing that so quickly.
The changeslook good to me modulo naming services nits
mentioned below.
I have picked up modified files and let js2ai generate profile
from sysidcfg file below (*).
Then I used generated SC profile to configure freshly installed
non-global zone with exclusive IP stack equipped with one 'anet'
resource (with link name 'net0').
I verified that after sysconfig finished, configuration was as
expected (**). In output below, some of information is masked
(name server addresses, DNS domains).
The only nit I see is with DNS, js2ai still requires
domain_name. According to William, domain name should not be
mandatory:
"For DNS, "domain_name" should not be required. "search", which specifies the
DNS
search list, should be supported. "domain_name" and "search" (the latter
allowing multiple values)
should be mutually exclusive."
I'm sorry I guess I wasn't clear in our earlier conversation on this subject. The requirement for domain name is specified in the Solaris 10 documentation as a required argument. Only the search
argument is optional.
Ah, ok. I was not aware of that aspect.
Since we are converting valid Jumpstart configuration the domain name argument
should be present in the sysidcfg file.
I can certainly make it optional but if it wasn't present in the sysidcfg name
service line then the statement would be illegal from a Solaris 10 perspective.
To be honest, I am not quite convinced it should be in scope
of js2ai tool to validate given sysidcfg file from S10 point
of view.
That said, given this information into account, I believe that fix
is fine as is - no need to change that at this point.
Thank you,
Jan
DNS Syntax for name_service Keyword
Use the following syntax to configure the system to use DNS.
name_service=DNS {domain_name=domain-name
name_server=ip-address,ip-address,ip-address
search=domain-name,domain-name,domain-name,
domain-name,domain-name,domain-name}
domain_name=domain-name
Specifies the domain name.
name_server=ip-address
Specifies the IP address of the DNS server. You can specify up to three IP
addresses as values for the name_server keyword.
search=domain-name
(Optional) Specifies additional domains to search for naming service
information. You can specify up to six domain names to search. The total length
of each search entry cannot exceed 250
characters.
- Kristina
That said, if fixing that would delay push,
I think it would be acceptable limitation at
this point.
Also, I haven't tested neither NIS nor LDAP. William
is more familiar with that area, so I will let him
verify that generated profiles are correct.
Jan
(*)
system_locale=C
terminal=vt100
network_interface=net0 {
hostname=sc-zone
ip_address=192.168.100.57
netmask=255.255.255.0
default_route=192.168.100.1
protocol_ipv6=yes
}
name_service=DNS {
domain_name=A.B.C
search=A.B.C,B.C
name_server=X.X.X.X,Y.Y.Y.Y
}
timezone=Europe/Prague
root_password=$5$dnRfcZse$Hx4aBQ161Uvn9ZxJFKMdRiy8tCf4gMT2s2rtkFba2y4
(**)
[1] locale (LANG smf property set to 'C')
# svcprop -p environment init
environment/LC_ALL astring ""
environment/LC_COLLATE astring ""
environment/LC_CTYPE astring ""
environment/LC_MESSAGES astring ""
environment/LC_MONETARY astring ""
environment/LC_NUMERIC astring ""
environment/LC_TIME astring ""
environment/TZ astring localtime
environment/value_authorization astring solaris.smf.value.environment
environment/LANG astring C
#
[2] timezone
# date
Wed Sep 21 10:04:40 CEST 2011
#
[3] terminal type
# svcprop -p ttymon/terminal_type console-login:default
vt100
# echo $TERM
vt100
#
[4a] net0 network interface configured with supplied static IPv4
[4b] IPv6 autoconfiguration enabled on net0
# ipadm show-addr
ADDROBJ TYPE STATE ADDR
lo0/v4 static ok 127.0.0.1/8
net0/v4 static ok 192.168.100.57/24
lo0/v6 static ok ::1/128
net0/v6 addrconf ok fe80::8:20ff:feb0:2a76/10
#
[5] IPv4 default route set correctly
# netstat -rn
Routing Table: IPv4
Destination Gateway Flags Ref Use Interface
-------------------- -------------------- ----- ----- ---------- ---------
default 192.168.100.1 UG 2 135 net0
127.0.0.1 127.0.0.1 UH 2 1302 lo0
192.168.100.0 192.168.100.57 U 3 0 net0
Routing Table: IPv6
Destination/Mask Gateway Flags Ref Use If
--------------------------- --------------------------- ----- --- ------- -----
::1 ::1 UH 2 42 lo0
fe80::/10 fe80::8:20ff:feb0:2a76 U 2 0 net0
#
[6] DNS configured and working
# cat /etc/resolv.conf
...
domain A.B.C
search A.B.C,B.C
nameserver X.X.X.X
nameserver Y.Y.Y.Y
# ping -a tio
tio (Z.Z.Z.Z) is alive
#
[7] root password (was able to log in as root)
# grep root /etc/shadow
root:$5$dnRfcZse$Hx4aBQ161Uvn9ZxJFKMdRiy8tCf4gMT2s2rtkFba2y4:6445::::::
#
On 09/21/11 04:36, Kristina Tripp wrote:
Good Evening. Please find an initial review the following changes that I've been given tentative approval for. I'm sending this out now despite testing being incomplete since I've been asked to
have this completed by COB tomorrow and the primary reviewers are in Prague.
https://cr.opensolaris.org/action/browse/caiman/enpointe/CR7092529/webrev/
7091163 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091163> js2ai should set
name of<ai_instance name=""> to profile name instead of default
7091196 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091196>
js2ai not processing filesys swap entry correct - vdev entry omitted
7092486 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7092486>
install/js2ai has incorrect license
7092529 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7092529>
js2ai - DNS conversion in sysidcfg is incorrect
7091377 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091377>
SC profile generated by js2ai(1m) tool does not configure some parameters correctly
Profile changes in conv.c were tested via Harold during some testing earlier in
the week
Testing of the changes in conv_sysidcfg.c is incomplete at this point in time
as I'm hoping William and/or Jan can test these changes for me
Testing a package install to ensure license info is installed properly is still
outstanding
Unit test all pass
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
