On 09/22/11 12:22, Darren Kenny wrote:
Hi Karen,
LGTM, the only concern is in mentioning a specific RFE number in the comments,
is it not the norm to omit such references in code?
It's appropriate, and helpful in recognizing future cleanup
opportunities, when we're working around a CR that is expected to be
fixed. That's the only case where it's really appropriate, though.
Dave
Thanks,
Darren.
On 22/09/2011 17:07, Karen Tung wrote:
Good morning,
I would like to get 2 reviews of my changes to fix:
7092870<http://monaco.us.oracle.com/detail.jsf?cr=7092870> The backup
/etc/svc/repository-boot is not deleted and occupy ram disk space
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/remove-smf-repo-backup/webrev/
Testing:
- I built all 5 images, booted each of them and made sure the SMF repo backup
file does not exist,
and I have more free space in the ramdisk.
- I run through the installs and rebooted to make sure there's no regression.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
