I have looked at the code changes and tested the generated package. Other than the issue that we talked about, which is the fact that the osnet-incorporation manifest license specification has 'must-accept=true' and this doesn't the changes look good. As long as Bonnie and David Comay are okay with this then I don't see a problem.

Harold

On 09/22/11 14:34, Sue Sohn wrote:
Can I get a couple of reviews of the changes for:

7093245 package install-image/solaris-auto-install has no license

Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7093245/webrev.7093245


Testing:
The install-image/solaris-auto-install package manifest built with these changes shows: license <hash> chash=<hash2> license=lic_OTN must-accept=true pkg.csize=4674 pkg.size=11984


I have successfully created a service with the package. Once the service is created, I can see the
license with:
pkg -R <imagedir> info --license.

I have also created a user image and attempted to install the package into it and was prompted to
accept the license:

pkg: The following packages require their licenses to be accepted before they can be installed or
updated:
----------------------------------------
Package: pkg://ai-image/install-image/[email protected],5.11-0.173.0.0.0.0.1376:20110922T192557Z

License: lic_OTN
  License requires acceptance.

To indicate that you agree to and accept the terms of the licenses of the packages listed above, use the --accept option. To display all of the related licenses, use the --licenses option.

Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to