I'm happy with things now, thanks for updating the bug. Thanks,
Darren. On 23/09/2011 18:54, Karen Tung wrote: > Hi Darren, > > Thank you for the code review. I updated 7078753 to indicate > why we can't generate a sort file for SPARC, and why it is not needed. > > Thanks, > > --Karen > > > > On 09/23/11 01:31 AM, Darren Kenny wrote: >> Hi Karen, >> >> The bug 7078753 suggests that maybe there should be a .sort file for the >> SPARC >> text image, but there isn't any included in this webrev... >> >> If it isn't required, then possibly the bug should be at least updated, but >> if >> it is required then maybe this is the time to do it? >> >> The fix for the nawk issue LGTM. >> >> Thanks, >> >> Darren. >> >> On 23/09/2011 08:26, Karen Tung wrote: >>> Hi everyone, >>> >>> I am looking for 2 reviewers for my changes for: >>> >>> 7078753<http://monaco.us.oracle.com/detail.jsf?cr=7078753> Time to redo >>> livecd.sort and text_x86.sort >>> 7094112<http://monaco.us.oracle.com/detail.jsf?cr=7094112> Text installer >>> boot >>> up shows error about /usr/xpg4/bin/awk not found >>> >>> webrev: >>> >>> https://cr.opensolaris.org/action/browse/caiman/ktung/new-iso-sort/webrev/ >>> >>> Note: >>> >>> I didn't make any changes to system-library-boot-management.mf for fixing >>> the 2 bugs above. This file appears on the webrev because I had to run >>> pkgfmt >>> on it. The gate does not build if I don't run pkgfmt on it. >>> >>> Testing: >>> >>> - I built Live CD and text installer x86 images with the updated iso sort >>> files. >>> - I booted up the Live CD and make sure the install is successful. >>> - I booted up the text installer and made sure the error about >>> /usr/xpg4/bin/awk >>> no longer shows up, >>> and I went through the install to make sure there's no regression. >>> >>> Thanks, >>> >>> --Karen >>> - >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
