Karen, I saw that in the CR. Thank. LGTM.
John On Sep 29, 2011, at 4:47 PM, Karen Tung wrote: > On 09/29/11 16:46, John Fischer wrote: >> >> Karen, >> >> Looks good. Should it say Oracle Solaris 11? > Hi John, > > Thank you for the review. > > We don't want to change it to say Oracle Solaris 11, because we don't want to > tie any release name to that string. Having it generic has the advantage > that we won't > need to change it as we ship new releases. > > Thanks, > > --Karen > >> >> John >> >> On 09/29/11 04:40 PM, Karen Tung wrote: >>> >>> Hi, >>> >>> I would like to get a couple of reviews for my simple change for the >>> following bug: >>> >>> >>> 7096046 text install still show build number >>> >>> webrev: >>> https://cr.opensolaris.org/action/browse/caiman/ktung/7096046/webrev/ >>> >>> Testing: >>> >>> I ran the updated script in a booted image and made sure the build number >>> doesn't show up, and everything else look good. >>> >>> Thanks, >>> >>> --Karen >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
