Seth,
Mostly questions below ...
legacygrub.py
------------------
881 - Just making sure here, but does this need a corresponding 'else'
clause?
885 - Same question.
923 - At this point, we expect at least one of bootfs_cmd or
findroot_cmd to have been updated and hence 'prepend_cmds' should be
non-empty here correct? Would it be worth it to check against that and
raise BootmgmtIncompleteBootConfigError() if not?
menu.lst.py:
---------------
123 - "should *be* the first"
127,134 - if idx ends up being -1 at these places, do we need to do
anything else or is simply falling through and appending the command to
the end of the entry what we want/expect to do?
-ethan
On 09/29/11 21:55, Seth Goldberg wrote:
Hi,
Can I please have a few reviewers for:
https://cr.opensolaris.org/action/browse/caiman/sethg/7096624/webrev/
This is a stopper and it's been fully tested (100% code coverage of
the changes verified with the coverage tool) with a variety of
menu.lst files.
Thanks,
--S
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
