Thank you for review, Drew.
That code was moved into __init__.py - lines 583-598.
I believe this is better place for that code, since
* it's unrelated to Summary screen
* it's now grouped with the code preparing engine - lines 573-578
* potential error message ("Failed to generate SC profile.") is no longer
overwritten when terminal is cleaned up by terminalui module.
Jan
On 10/17/11 15:07, Drew Fisher wrote:
Jan,
This looks ok to me. One question though: Where do you execute the
ManifestWriter checkpoint now that the on_continue() method has been
removed from summary.py?
-Drew
On 10/17/11 6:58 AM, Jan Damborsky wrote:
Hi Ginnie, Drew,
could I please ask you to review couple of sysconfig bug fixes for
following CRs ?
7066863 'sysconfig create-profile' in a ROZR zone causes a traceback
7099567 InstallLogger.__init__() manipulates incorrect dir for other
than DEFAULTLOG file
7097639 sysconfig configure -c file.xml generates stack trace due to
path not including . and /usr/sbin
7079796 sysconfig create-profile is silent about write failures
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7066863/webrev/
Those fixes target U1 (not S11FCS).
Thank you,
Jan
tests done:
[1] regression tests
* built all install images (Sparc, x86) using modified Distribution
Constructor
* tested AI, text installation, GUI installation
[2] CR specific tests
* 7097639
- in ROZR zone booted in writable mode, successfully run
'sysconfig configure -c <profile>' withPATHunset.
Following tests done in ROZR zone booted in read-only mode:
* 7066863
- 'sysconfig create-profile' didn't generate traceback
- log file was redirected /system/volatile/sysconfig.log
- SC profile created in /system/volatile/profile/sc_profile.xml
* 7099567
- verified that logger no longer tries to create
/var/tmp/install when 'sysconfig create-profile'
is run
* 7079796
- verified that 'sysconfig create-profile' exits with error
when profile can't be created:
# sysconfig create-profile -o /sc.xml ; echo $?
Failed to generate SC profile.
Exiting System Configuration Tool. Log is available at:
/system/volatile/sysconfig.log
1
#
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
