Let the code reviews commence!

Could I please get a code review for

7092599 <http://monaco.us.oracle.com/detail.jsf?cr=7092599> distro-constructor can build invalid LiveCD when svccfg fails

https://cr.opensolaris.org/action/browse/caiman/drewfish/7092599/webrev/

I tested this by building 175 on a host system running 173 (there was an SMF schema change in 174):

<snip detail log>
2011-09-29 17:17:42,853 InstallationLogger DEBUG Executing: ['/usr/sbin/svccfg', 'list', '*desktop-cache*']
2011-09-29 17:17:43,686   InstallationLogger DEBUG
application/desktop-cache/gconf-cache
application/desktop-cache/mime-types-cache
application/desktop-cache/icon-cache
application/desktop-cache/desktop-mime-cache
application/desktop-cache/pixbuf-loaders-installer
application/desktop-cache/input-method-cache


This works because we're now correctly setting all of the proper SMF environment variables, exactly the same way that we do when we import all the services.

Thanks!

-Drew
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to