Hi Drew,
Thank you so much for fixing this bug.
I got a couple of comments.
- When we were discussing the changes for this bug, I remembered we want
to add some comments
in the Partition.resize() and Slice.resize() functions so people are
aware that those functions
will not check the new size to make sure it fits correctly. People are
advised to use resize_partition()
or resize_slice().
- The code for resize_slice() function in the Disk and Partition object
looks identical to me.
resize_partition() looks very similar to resize_slice() too. Is it
possible to consolidate and
eliminate most of the duplicate code?
Thanks,
--Karen
On 10/24/11 07:19, Drew Fisher wrote:
Good morning!
Could I please get a code review for:
7089672 <http://monaco.us.oracle.com/detail.jsf?cr=7089672> Shrinking
1st partition with 2 partitions in S11 text installer crashes
https://cr.opensolaris.org/action/browse/caiman/drewfish/7089672/webrev/
I tested this by replicating the issue in the CR as well as writing
new unittests for each permutation of slice (or partition) and gap.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
