Kristina,
let me review those changes.
I will get back to you with comments later this week.
Jan
On 10/25/2011 09:42 PM, kristina tripp wrote:
Good afternoon
Could I please get a code review for:
7074408 js2ai should report errors for failure on each line in rules
file.
7098250 js2ai doesn't choose proper network to convert primary key is
used
7097410 Teach js2ai to avoid converting obsoleted SPARC platforms
found in JumpStart rules files
7083430 nosexunit test failure for solaris_install/js2ai/conv_sysidcfg.py
7097822 js2ai fails with exception when profile or manifest path ends
with "/"
7097883 js2a incorrectly turns on Auto Network instead of Default when
name_service is set in sysidcfg
7103161 js2ai doesn't delete old sc_profile before processing new
sysidcfg
https://cr.opensolaris.org/action/browse/caiman/enpointe/CR7097883/webrev/
Expanded the unit test to make sure the DefaultFix or Automatic was
set for the network based on the settings being processed.
Unit tests - PASSED
indiana-build> slim_test cmd/js2ai/modules/test
[ text -deleted]
----------------------------------------------------------------------
Ran 236 tests in 15.482s
OK
ok
----------------------------------------------------------------------
Ran 237 tests in 31.916s
OK
Additional Testing:
Performed a series of sysidcfg translation and system reconfiguration
of the resulting sc_profile using sysconfig.
As part of the root_account change for CR in addition to a sysconfig
test also diff a diff of sc_profile.xml before the changes associated
with CR and after to ensure that the only addition to the xml was the
type field
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
