Looks good to me, Drew. /jb
On Nov 8, 2011, at 11:06 AM, Drew Fisher wrote: > Good morning! > > Could I please get a code review for the following CR: > > 7091282 Installers do not report large-sector-size disks correctly > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7091282/webrev/ > > > This CR is a fix of only the display of disks in all three installers. What > was happening was the blocksize of the disk was not being passed to the Size > object. The Size objects default to a blocksize of 512b so the 4k blocksize > disks were showing up at 1/8th of their original size. > > There is still pending ON work from another team (see CR 7079565 and a > still-pending ARC case) which will address changes to the sd driver to > support full installations to these types of disks. > > Thanks! > > -Drew > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
