After several conversations I only have a few nits. I don't need to see
an updated webrev on this.
image.py:
132: Should the comment be changed from rename to move?
There should be a comment explaining why a simple rename is not sufficient.
service.py:
1284: This could move to 1305 since it is only referenced if arch is x86.
Testing:
On x86 did you create clients of a service and alias prior to the
set-service and verify that they correctly booted afterward?
Did you try moving the image across file systems?
Harold
On 11/21/11 11:43, Sue Sohn wrote:
Can I get a code review of the changes for:
7110679 Enhance set-service to change location of service's imagepath
7107347 Remove 'livemode=text' from menu.lst file generated for x86 AI
service
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7110679_7107347/webrev.7110679_7107347
Testing:
Performed following tests for sparc and x86:
Create service. Ensure client boots and installs from service.
Modify imagepath with set-service. Ensure client still boots and
installs.
Create alias. Ensure client boots and installs from alias.
Modify imagepath with set-service. Ensure client still boots and
installs.
In addition, QA ran similar manual client testing on both sparc and
x86 AI servers and ran the installadm test suites (no regressions).
Ran unit tests (newly added tests pass and no regressions on existing
tests).
Verified that livemode=text was no longer in menu.lst files generated
by create-service.
Supporting bugs filed:
o Test Suites:
7110689 Enhance test for installadm set-service to test new option,
imagepath=<newpath>
o Install Guide:
7112696 Install guide should be updated to reflect new imagepath
option to installadm set-service
7112703 Install guide should be updated to reflect changes for 7107347
o installadm(1m) manpage:
7112705 update installadm man page to include new imagepath option
for set-service subcommand
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
