Ginnie,
thank you very much for review.
I agree with all your comments and I made appropriate changes
to reflect them. I have updated webrev accordingly:
full:
https://cr.opensolaris.org/action/browse/caiman/dambi/7102684-cr/webrev-cr/
incremental:
https://cr.opensolaris.org/action/browse/caiman/dambi/7102684-cr-diff/webrev-cr-diff/
Jan
On 11/23/11 21:31, Virginia Wray wrote:
Hi Jan --
Thanks for working on these. A couple of comments....
network_types.py
-----------------------
lines 110 - 117: It would be a little more readable to use names for
the return from NetworkInfo.find_links() rather than dumping into
self.ether_nics and using self.ether_nics[0] and self.ether_nics[1].
i.e. ethernics, nic_num = NetworkInfo.find_links(), or something
similar.
network_info.py
----------------------
ln 95: It looks like, you could return FROMGZ_NICS_NUM could be returned
before it's given a value (ln 117). I can't find where is initialized
elsewhere.
ln 305 - and ln 312: could you put a description of what is being
returned, similar to the description line at line 291.
Otherwise, it looks good.
thanks,
ginnie
On 11/22/11 02:21 AM, Jan Damborsky wrote:
Hi Ginnie, Drew,
could I please ask you to review couple of sysconfig bug fixes ?
7085865 installer in zones lost zonename as inital proposed system name
7090563 sysconfig create-profile fails to configure networking for
shared-IP zones
7029779 sysconfig netmask validation should be stronger
7102684 sysconfig summary is incorrect with no networking
6996540 Convert sysconfig to use ipadm instead of ifconfig
7105452 inconsistent use of single and double quotes in SC sample files
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7102684/webrev/
Thank you,
Jan
tests done:
[1] regression tests
* built all install images (Sparc, x86) containing modified bits
* tested AI, text installation, GUI installation
[2] CR specific tests
* 7085865
- tested freshly installed zone configured in interactive
way. SCI tool defaulted to zone name for nodename configuration
on 'Network' screen.
* 7090563
- verified that 'sysconfig create-profile' brought up
configuration screens for naming services
* 7029779
- tested various network masks. Verified that invalid ones which
were previously considered valid (e.g. 1.1.1.1) are no longer
being accepted.
* 7102684
- verified that in non-global zone with exclusive IP stack and with
all NICs configured with allowed-address Summary screen now following
message (reviewed by Seb from networking team):
Network Configuration: Mandated from global zone
* 6996540
- verified that for text installer (tested both boot from media and
network)
DNS config is pre-populated from DHCP values.
[3] unit tests
* successfully run unit tests for text install and sysconfig
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
