Nirmal,

Thanks for fixing this ...

On 11/30/11 11:05, Nirmal Agarwal wrote:
Hi all

Could I please get a code review for the following CR :

7006611 installadm should recognise hostname as a criteria for manifests

Webrev location :

https://cr.opensolaris.org/action/browse/caiman/nirmal27/Cr7006611

The change looks fine.


Manual tests
------------------
Location :
/net/indiana-build/export/home/na210770/ai/7006611/Manual-Tests

Could you run through a create-manifest test using the hostname criteria (just to make sure there's nothing in that codepath that would prevent this from working in that case.)

Also, could you run the cmd/ai-webserver unit tests to make sure nothing needs adjustment there.


thanks,
-ethan


Additional CR's :
--------------------
CR (7114896, 7114893) filed  for manpage and doc changes.

Installadm test suite CR  7114952


Regards
Nirmal

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to