Hi:
Could I please get a code review for the following test suite bug:
7116813 <http://monaco.us.oracle.com/detail.jsf?cr=7116813> obsolete
test_ai_smf_service.py should be removed from gate
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7116813
The following testing had been done:
1. Before the fix, when you run slim_test cmd/installadm, the test use
to fail and had stack trace with one error:
The test result output is in
/net/indiana-build/export/home/ding/7116813_before/slim_source/test_results
./slim_test cmd/installadm
( a big list of output)
ERROR: test suite for <class 'test_ai_smf_service.TestAISmfService'>^M
----------------------------------------------------------------------^M
Traceback (most recent call last):^M
File
"/usr/lib/python2.6/site-packages/nose-0.11.3-py2.6.egg/nose/suite.py", l
ine 197, in run^M
self.setUp()^M
File
"/usr/lib/python2.6/site-packages/nose-0.11.3-py2.6.egg/nose/suite.py", l
ine 280, in setUp^M
self.setupContext(ancestor)^M
File
"/usr/lib/python2.6/site-packages/nose-0.11.3-py2.6.egg/nose/suite.py", l
ine 303, in setupContext^M
try_run(context, names)^M
File
"/usr/lib/python2.6/site-packages/nose-0.11.3-py2.6.egg/nose/util.py", li
ne 491, in try_run^M
return func()^M
File
"/export/home/ding/7116813_before/slim_source/usr/src/cmd/installadm/smf_
test/test_ai_smf_service.py", line 99, in setUpClass^M
add_prop_group(cls.pgname)^M
File
"/export/home/ding/7116813_before/slim_source/usr/src/cmd/installadm/smf_
test/test_ai_smf_service.py", line 65, in add_prop_group^M
fail('cmderr cmd: %s failed with: %s') % (cmd, cmderr)^M
fail('cmderr cmd: %s failed with: %s') % (cmd, cmderr)^M
NameError: global name 'fail' is not defined^M
^M
----------------------------------------------------------------------^M
Ran 67 tests in 0.321s^M
^M
FAILED (SKIP=1, errors=1)^M
2. After the fix, slim_test cmd/installadm no longer fails:
The test result output is in
/net/indiana-build/export/home/ding/7116813/slim_source/test_results
#258 Ensure options with missing value caught ... Usage: ^M
set-service -o|--option <prop>=<value> <svcname>^M
prop=value can be:^M
aliasof=<existing_service>^M
default-manifest=<manifest/script name>^M
imagepath=<newpath>^M
^M
nosetests: error: Missing required argument, <svcname>^M
ok^M
#259 Test proper processing. ... ok^M
^M
----------------------------------------------------------------------^M
Ran 67 tests in 0.252s^M
^M
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
