Hi Tomas,
Looks good to me, I do have a small nit:
- test_ai_database.py, line 259:
s/addres/address/
Thanks,
Darren.
On 05/12/2011 12:59, Tomas Dzik wrote:
> Hi all,
> I would like to ask you for a code review for the following bug:
>
> 7117539 installadm prints network criteria unformated
>
> Webrev is here:
>
> https://cr.opensolaris.org/action/browse/caiman/t.dzik/7117539/
>
> Testing:
>
> 1) Sources are pep8 clean
> 2) I run the test-suite in gate (and fixed also the test suite).
> 3) I installed my fix on test machine and verified that network
> is now printed formated as ipv4 address.
>
> Output before fix:
>
> root@S11:~# installadm list -m -n default-i386
>
> Manifest Status Criteria
> -------- ------ --------
> default ipv4 = 192.168.1.15
> network = 192168001000
>
> orig_default Default None
>
> Output after fix:
>
> root@S11:~# installadm list -m -n default-i386
>
> Manifest Status Criteria
> -------- ------ --------
> default arch = i386
> ipv4 = 192.168.1.15
> network = 192.168.1.0
>
> orig_default Default None
>
> Best regards,
>
> Tomas D.
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
