On 11/30/11 04:14 AM, Tomas Dzik wrote:
Hi all,
I would like to ask you for a code review for bug:
7052679 AI Sparc client gets wantboot.conf error when booting due to
restrictive umask
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7052679/
Testing:
1) I built the gate with fix on x86 and on sparc.
2) Using distro constructor I created AI iso image on both platforms
3) I created virtual machines on x86 and on sparc and updated these machines to
the built gate
4) I set umask for root to 0066 (as reported in bug)
5) On x86 I created install service. For sparc I created it from publisher and
for x86 I created it
from built AI iso image
6) I verified permissions of wanboot.conf and system.conf
7) I modified manifest, added it as a new default manifest and installed x86
client (also on virtual
machine) from this AI server.
I observed that client installed correctly.
8) On sparc I created install service for sparc from built iso, added new
default manifest and also
added new profile. (All command were run with umask set to 0066.)
9) I installed sparc client from this AI server and verified that client
installed correctly and
used the right manifest and profile.
10) Sources are pep8 clean.
Best regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Tomas,
Just one nit in dhcp.py:
492 it's -> its
Otherwise, looks good. No need to see another webrev.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
