Hi:

Could I please get a code review for the following test suite bug:

7114115 <http://monaco.us.oracle.com/detail.jsf?cr=7114115> test_missing_iso is run on SPARC (and fails)


Webrev is here:

'https://cr.opensolaris.org/action/browse/caiman/md5645/7114115

The following testing had been done:

1. On x86, I confirm the test_create_usb.py works fine after the fix:


indiana-build{ding}1172: cd tools/tests
/export/home/ding/7114115/slim_source/usr/src/tools/tests
indiana-build{ding}1173: sudo bldenv -d ../../de*sh
Build type   is  DEBUG
RELEASE      is
VERSION      is 5.11
RELEASE_DATE is December 2011

Using csh as shell.
indiana-build# ./slim_test cmd/distro_const/checkpoints/test/test_create_usb.py
#71 test_missing_iso (test_create_usb.TestCreateUSB) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.048s

OK
indiana-build# pwd
/export/home/ding/7114115/slim_source/usr/src/tools/tests
indiana-build#


2.  On sparc, I confirm the test_create_usb.py is skipped after the fix:

line1-m3000{ding}71: cd tools/tests
/export/home/ding/7114115/slim_source/usr/src/tools/tests
line1-m3000{ding}72: sudo bldenv -d ../../de*sh
Build type   is  DEBUG
RELEASE      is
VERSION      is 5.11
RELEASE_DATE is December 2011

Using csh as shell.
line1-m3000# ./slim_test cmd/distro_const/checkpoints/test/test_create_usb.py /usr/lib/python2.6/site-packages/nose-1.0.0-py2.6.egg/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin nosexunit = nosexunit.plugin:NoseXUnit: pygments>=1.0
  RuntimeWarning)
#1 test_missing_iso (test_create_usb.TestCreateUSB) ... SKIP: Not on i386

----------------------------------------------------------------------
Ran 1 test in 0.003s

OK (SKIP=1)
line1-m3000#

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to