Hi Jack,
I agree with your suggestion and will make that change.
Thanks for review !
Jan
On 12/14/11 05:28 PM, Jack Schwartz wrote:
HI Jan.
One nit:
welcome.py: The whole curses module is imported for just
curses.KEY_ENTER. I suggest changing line 29 to import only
curses.KEY_ENTER.
Else looks fine to me.
Thanks,
Jack
On 12/14/11 04:15 AM, Jan Damborsky wrote:
Hi Ginnie, Drew,
could I please ask you to review fix for following CR ?
7105380 zlogin -C after sysconfig started appears to be dead console
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7105380/webrev/
Thank you,
Jan
tests done:
[1] regression tests
* built text & AI install images (Sparc, x86) containing modified bits
* tested AI, text installation (booted from media and network)
[2] CR specific tests
- booted freshly installednon global zone
- waited for SCI tool invoked on zone's console
- after that, attached to zone's console via 'zlogin -C <zone>'
- verified that sysconfig Welcome screen was redrawn after
one one 'redraw keys' introduced by this fix (Enter, Spacebar)
was pressed.
[3] unit tests
* successfully run unit tests for sysconfig and terminalui
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
