Jesse,
This looks good. Just one minor nit:
693 cfgfile = self._properties['config_file']
694 with open(cfgfile, 'a') as cfg:
695 cfg.writelines(lines)
Why not just do:
694 with open(self._properties['config_file'], 'a') as cfg:
695 cfg.writelines(lines)
That way you don't have to keep a variable around for just one line.
-Drew
On 12/15/11 3:28 PM, Jesse Butler wrote:
Please review my changeset for the following two CRs:
7087888 <http://monaco.us.oracle.com/detail.jsf?cr=7087888>installadm
create-service may create faulty DHCP configuration when DNS is not
enabled
7087905 <http://monaco.us.oracle.com/detail.jsf?cr=7087905> installadm's dhcp
support should include NIS
These changes fix an issue where the CLI was adding lines for DNS
services even if they weren't configured (which resulted in blank
spaces in the line, which would cause the DHCP server to go into
maintenance) and also add support for NIS.
The existing implementation adds DNS only, whether or not it is
configured. With these changes, both DNS and NIS will be checked and
added to the configuration if the client services are enabled, and
will be left out of the config if they aren't enabled.
https://cr.opensolaris.org/action/browse/caiman/jesseb/dhcp_ns/webrev/
Thanks
Jesse
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
