Hi Johg and Jack, I used the format string as you suggested and the new webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7083848-3/ Is that OK now ? Regards, Tomas D. Dne 19.12.11 18:00, John Fischer napsal(a):
Tomas, Thanks for working on this issue. Having clear error messages is an important part of any quality product. The code: 525 print>> sys.stderr, cw(_("The specified data source for the net" + 526 " image ") + options.srcimage + _(" is not path to the " + 527 "existing ISO image.")) 528 print>> sys.stderr, cw(_("Attempt to create net image from " + 529 "pkg(5) package ") + options.srcimage + 530 _(" failed from following reasons:")) 531 if isinstance(err, pkg.client.api_errors.VersionException): 532 print>> sys.stderr, cw(_("The IPS API version specified, " 533 + str(err.received_version) + 534 ", is incompatible with the expected version, " 535 + str(err.expected_version) + ".")) I know that your changes fit in with what is already there at lines 531-535. However, it seems like it would be awkward to translate. Why not use the format string version instead ("some stuff %s more stuff")? Also the wording seems difficult to parse. Thanks, John On Dec 19, 2011, at 4:39 AM, Tomas Dzik wrote:Hi all, I would like to ask you for a code review for a bug: 7083848 - installadm create-service generates confusing error messages if non-existent iso specified Webrev: https://cr.opensolaris.org/action/browse/caiman/t.dzik/7083848/ Testing: 1) Source is pep8 clean 2) The new output if non-existent iso is specified: root@S11:~# installadm create-service -n test1 -s /tmp/noexist.iso Warning: Automatic network configuration is enabled. Please be sure that the IP address for S11 is static. Creating service from: /tmp/noexist.iso OK to use default image path: /export/auto_install/test1? [y/N]: y The specified data source for the net image /tmp/noexist.iso is not path to the existing ISO image. Attempt to create net image from pkg(5) package /tmp/noexist.iso failed from following reasons: The following pattern(s) did not match any allowable packages. Try using a different matching pattern, or refreshing publisher information: /tmp/noexist.iso Best regards, Tomas D. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
