I originally started going down that path but decided to do it this way
because it was already being done this way in installadm list and
because the user will be notified that the service is not usable the
next time that it is enabled. Your suggested change would let the user
know earlier and in a more obvious way that there is a problem with the
service. Let me look into it. I will post a new webrev when it is done
and tested.
Harold
On 12/29/11 10:01, Dave Miner wrote:
Harold, WRT 7090169, I wonder if we should be making the fact that
these services are really not usable more visible (in all cases, not
just the -c case you're fixing). The "-" in the Arch column seems
pretty subtle to me, perhaps we should be flagging the image path as
being bad more clearly (parenthesize it, or otherwise annotate it
somehow). Thoughts?
Dave
On 12/28/11 17:00, Harold Shaw wrote:
May I get a code review for the following installadm bugs:
7060060 Informational message to report bad image should
include service name
5393 Automated Installer should not allow setting up non-AI
images and should check validity of image
7090169 installadm list doesn't detect when the image
directory
has been removed
Webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/5393
Testing:
Create an AI service from a valid ISO
Create an AI service from a valid package
Attempt to create AI service from ISO with:
- no solaris.zlib
- no auto_install/ai.dtd
This was done by attempting to create a service from a text install iso
and a hand modified iso (to get rid of solaris.zlib).
Disable and enable valid services
Disable valid services, make them invalid (remove the image dir, get rid
of auto_install or solaris.zlib), and then attempt to enable them
installadm list
remove image directory, run installadm list, and verify that it runs
successfully replacing the Arch value with '-'
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
