Hi all,
I would like to ask you for a code review for a bug
7015427 - installadm does not validate criteria values
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7015427/
Couple of questions:
1) Could you please check the wording of Warnings I added ?
2) Is it OK just to print warnings or should I rise the exception ?
I decided just to print warning because in such case my changes will not
prevent installation of the potential new architectures but I can change
it if you feel that Error is more appropriate here.
Testing:
1) Sources are pep8 clean.
2) Tests passed
3) I tried to create manifest and profile with criteria cpu and arch,
using allowed and not-allowed cpus and archs, using single value and
lists of value and I checked that proper warnings are printed and
criteria updated.
4) I tried also installadm set-criteria command.
5) I tried to set criteria using also .xml file
Best regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
