Hi John,
the only reason why I split this test into it's own file was that Mary
suggested that I should consider splitting it.
I think it depends only on personal preferences what someone consider to
be "nicer" so I agree with both ways - I just need to find consensus on
this mailing list.
Best regards,
Tomas D.
On 16.1.2012 18:44, John Fischer wrote:
Tomas,
Why create a new test file instead of just adding the check and SkipTest
exception
to the current file? Does raising SkipTest cause all the other tests to be
skipped?
If so then I am fine with how this is written.
Thanks,
John
On Jan 16, 2012, at 8:22 AM, Tomas Dzik wrote:
Hi,
I would like to ask you for a code-review for:
7129922 test_create_service.DHCPServerTest.test_permissions unit test failure
after 7052679 is putback
webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7129922/
I fixed the above mentioned bug and also moved dhcp server test into it's own
test file.
Testing done:
1) I run unittest in gate and test reported:
#142 Test correct permissions of dhcpd4.conf ... ok
2) I removed installadm and dhcpd commands from test machine using following
commands:
# pkg uninstall pkg://solaris/install/installadm
# pkg uninstall pkg:/service/network/dhcp/isc-dhcp
3) I run unittests again and test reported:
#142 Test correct permissions of dhcpd4.conf ... svcs: Pattern
'svc:/network/dhcp/server' doesn't match any instances
SKIP: DHCP SMF service not available
Best regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
