Mary, Looks good.
John On Jan 31, 2012, at 4:47 PM, Mary Ding wrote: > Hi: > > Could I get a code review for the following CRs related to slim_unit tests: > > 7132996 test_pre_pkg_img_mod.py will fail if SUNWcs does not exist on the > test machine > > http://monaco.us.oracle.com/detail.jsf?cr=7132996 > > 7133001 test/test_cpio.py will fail if /etc/X11/fontpath.d does not exist on > the test machine > > > http://monaco.us.oracle.com/detail.jsf?cr=7133001 > > > 7133833 aimdns unit tests will not work due to SkipTest error logic if > service is not enabled. > > > http://monaco.us.oracle.com/detail.jsf?cr=7133833 > > > Webrev location: > > https://cr.opensolaris.org/action/browse/caiman/md5645/7132996_7133001_7133833 > > Testing for 7132996 and 7133001: > > I ran the slim install unit tests and there is no more failure on the test > machine tcu27-01 and osol-bldsp. There is no more failures. > > > Testing for 7133833: > > 1. Case where installadm is not installed - the aimdns unit test were skipped. > > 2. Case where system/install/server is installed but is disable - the aimdns > unit test were skipped. > > 3. Case where system/install/server is installed but in maintainence mode - > the aimdns unit test were skipped > > 4. Case where system/install/server is installed and enabled - the aimdns > unit tests were run and tests failed due to bugid 7000918. > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
