Thanks for the review Mary.
On 01/30/12 18:14, Mary Ding wrote:
Matt:
My comments are just nits:
1. Since you are modifying usr/src/lib/install_common/__init__.py.src,
can you fix the following pep8 error on line 69:
Instead of:
IMG_AI_MANIFEST_DTD = os.path.join(IMG_AI_MANIFEST_PATH ,
It should be:
IMG_AI_MANIFEST_DTD = os.path.join(IMG_AI_MANIFEST_PATH,
Done
cheers
Matt
Otherwise, everything looks good.
On 01/30/12 09:50 AM, Matt Keenan wrote:
Hi,
Can I get CR for following bug :
7130956 - Change default log location to /var/log/install
http://monaco.us.oracle.com/detail.jsf?cr=7130956
Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7130956/
This fix is a follow on from the recently integrated bug 7107775, and
turned out to be a lot less painful than envisioned, in fact rather
trivial.
Testing :
- Built all three ISOS ai/text/gui and test installed to ensure logs
are being installed to /var/log/install
- Ran complete set of unit tests and no regressions found.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
